Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: update to 1.8.0 #287

Merged
merged 3 commits into from
Mar 12, 2025
Merged

android: update to 1.8.0 #287

merged 3 commits into from
Mar 12, 2025

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Oct 1, 2023 •
edited
Loading

Starting with 1.6.0 it requires minSdk 34! Titanium doesn't support that yet. It's just so we have the PR already and know about the issue :)

Changelog: https://developer.android.com/jetpack/androidx/releases/browser#1.8.0

[ERROR] [GRADLE]      The minCompileSdk (34) specified in a
[ERROR] [GRADLE]      dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
[ERROR] [GRADLE]      is greater than this module's compileSdkVersion (android-33).

ti.webdialog-android-2.4.0.zip

@hansemannn
Copy link
Contributor

Hi @m1ga Should we do this?

@m1ga
Copy link
Contributor Author

m1ga commented Mar 10, 2025

let me update the manifest to minsdk:12.6.0 but then we should be fine here.

@m1ga
Copy link
Contributor Author

m1ga commented Mar 10, 2025

I've raised the version to 1.8.0 and set the manifest to 12.6.0. The included example/app.js still opens the dialog and it has a green bar.

ZIP in the first post is updated too

@m1ga m1ga marked this pull request as ready for review March 10, 2025 16:01
@m1ga m1ga changed the title android: update to 1.6.0 android: update to 1.8.0 Mar 10, 2025
@hansemannn hansemannn merged commit 39479dd into master Mar 12, 2025
1 check passed
@hansemannn hansemannn deleted the android1_6 branch March 12, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @hansemannn